Skip to content

[12.x] Add an AsEncryptedFluent cast class #56220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

michaeldzjap
Copy link
Contributor

@michaeldzjap michaeldzjap commented Jul 5, 2025

This PR adds a an AsEncryptedFluent cast class to complement the already existing AsFluent cast class.

NOTE: I was planning on adding tests, but noticed that all tests concerning encrypted cast logic are commented out in DatabaseEloquentModelTest for some reason.

Copy link

github-actions bot commented Jul 5, 2025

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@michaeldzjap michaeldzjap marked this pull request as ready for review July 5, 2025 13:07
@michaeldzjap michaeldzjap changed the title Add an AsEncryptedFluent cast class [12.x] Add an AsEncryptedFluent cast class Jul 5, 2025
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@michaeldzjap
Copy link
Contributor Author

Is there anything I can do to have this PR re-considered? I understand that adding a new feature, especially when its untested / untestable is a no go. What is the reason the current encrypted cast logic is commented out if I may ask? Is this something that is fixable? If so, I'm happy to take a look at it if would mean my PR could be re-considered.

I understand that Laravel receives a ton of PR requests, so there is no pressing urge to re-ignite this, but I though I would ask anyway. I really could use an encrypted version of the AsFluent class that is integrated into the framework codebase itself, as the modification in the HasAttributes trait is pretty essential for it to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants